This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18506 ) Change subject: gsm23236: add TMSI and NRI utility functions for MSC pooling ...................................................................... Patch Set 2: (1 comment) This change is ready for review. https://gerrit.osmocom.org/c/libosmocore/+/18506/2/src/gsm/gsm23236.c File src/gsm/gsm23236.c: https://gerrit.osmocom.org/c/libosmocore/+/18506/2/src/gsm/gsm23236.c@36 PS2, Line 36: int16_t > Why is it signed? Can the NRI be negative? In the end, no real reason, just "why not". The NRI is normally <= 10 bit wide, as per 3GPP TS 23.236. (I'm going to allow up to 15 bits, because there is no hard limit up to 24 bits, but 15 is also far above what anyone would likely ever use.) I want to use negative NRI to indicate invalid or that none has been set. Come to think of it, I think I'm not actually using that anywhere now that these functions return an error code instead of an NRI, but it seems a good idea to keep some room in the definition from the start, since we are getting it for free. The easiest is to take <0 meaning invalid, given the ample unused number space. We could also use 'int', actually. Just thought the int16_t might be more specific on how little of the int will really be used. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18506 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icb57a2dd9323c7ea11b34003eccc7e68a0247bf5 Gerrit-Change-Number: 18506 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-CC: Vadim Yanitskiy <vyanitskiy at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 02 Jun 2020 15:23:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Vadim Yanitskiy <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200602/bc14e2bc/attachment.htm>