Change in libosmocore[master]: gsm23236: add TMSI and NRI utility functions for MSC pooling

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Tue Jun 2 15:49:58 UTC 2020


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18506 )

Change subject: gsm23236: add TMSI and NRI utility functions for MSC pooling
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/18506/2/src/gsm/gsm23236.c 
File src/gsm/gsm23236.c:

https://gerrit.osmocom.org/c/libosmocore/+/18506/2/src/gsm/gsm23236.c@36 
PS2, Line 36: int16_t
The function itself returns an error code:

> \return 0 on success, negative on error (i.e. if nri_bitlen is not in the valid range).

and this is fine. Let's either make it return NRI, so it can be negative in case of an error, or change pointer type to 'uint16_t *'. The current function signature is confusing.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18506
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icb57a2dd9323c7ea11b34003eccc7e68a0247bf5
Gerrit-Change-Number: 18506
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 02 Jun 2020 15:49:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200602/b04ee58c/attachment.htm>


More information about the gerrit-log mailing list