This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/19121 )
Change subject: mgcp_vty: fix endpoint number configuration
......................................................................
Patch Set 5: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/c/osmo-mgw/+/19121/3/src/libosmo-mgcp/mgcp_trunk.c
File src/libosmo-mgcp/mgcp_trunk.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/19121/3/src/libosmo-mgcp/mgcp_trunk.c@45
PS3, Line 45: trunk->virtual.vty_number_endpoints = 32;
: trunk->e1.vty_timeslot_first = 1;
: trunk->e1.vty_timeslot_num = 2;
> Just thought that a bit of flexibility would not hurt. […]
we should open timeslots at the time of a CRCX. IF it succeeds - great. If it fails -> return an error message. I think adding code complexity about ranges, or even configuration complexity does not serve any purpose here (other than open up new ways of how things can go wrong).
So either we allocate all endpoints for all timeslots (15*30=450 per E1 trunk) at start-up, or we dynamically allocate them by demand whenever we get the related CRCX.
Pre-allocating all of them sounds like a bit of a waste, at 64 trunks * 450 we end up with 28800 endpoints. Not sure how large our data structures are, but even if an endpoint would be 1kB, it's "only" 28MB of total RAM _if_ somebody went for full 64 trunks. Not elegant, but not a big desaster with todays memory sizes.
And if we are worried about this, we could make the creation of sub-slot endpoints optional, i.e. allow only 64k slots for the non-Abis cases (A interface, classic ISDN) and only go for the full I.460 in Abis use cases.
Honestly, I don't think it's worth spending any effort in optimization now. So let's just allocate all possible endpoints for each E1 trunk at startup/config time and avoid additional complexity about ranges.
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19121
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I73b31e3c236a61ea0a6f76ef5ff98ce589f52c77
Gerrit-Change-Number: 19121
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Jul 2020 10:33:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200709/0a8de142/attachment.htm>