This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/19121 ) Change subject: mgcp_vty: fix endpoint number configuration ...................................................................... Patch Set 5: (2 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/19121/5/include/osmocom/mgcp/mgcp_trunk.h File include/osmocom/mgcp/mgcp_trunk.h: https://gerrit.osmocom.org/c/osmo-mgw/+/19121/5/include/osmocom/mgcp/mgcp_trunk.h@51 PS5, Line 51: } v; that's a bit drastically short, but ok :) https://gerrit.osmocom.org/c/osmo-mgw/+/19121/2/src/libosmo-mgcp/mgcp_vty.c File src/libosmo-mgcp/mgcp_vty.c: https://gerrit.osmocom.org/c/osmo-mgw/+/19121/2/src/libosmo-mgcp/mgcp_vty.c@936 PS2, Line 936: vty_out(vty, " timeslot first %u%s", > You are probably right, this patch is more about adding features. […] after laforge questions that these values should be configurable at all, it adds to the argument that you should maybe rather add the configurability in a separate patch, and just fix the off-by-one problem in this patch -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I73b31e3c236a61ea0a6f76ef5ff98ce589f52c77 Gerrit-Change-Number: 19121 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Thu, 09 Jul 2020 01:12:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier at sysmocom.de> Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200709/5a3ceff4/attachment.htm>