Change in osmo-pcu[master]: csn1: fix this statement may fall through [-Werror=implicit-fallthrou...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Jan 28 21:38:29 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17005 )

Change subject: csn1: fix this statement may fall through [-Werror=implicit-fallthrough=] found by gcc7
......................................................................

csn1: fix this statement may fall through [-Werror=implicit-fallthrough=] found by gcc7

Port of wireshark.git commit fd68c7dfc7d06ce7babe914f2575d9e4f35988ad.

Ported-by: Pau Espin Pedrol <pespin at sysmocom.de>
Change-Id: Ibaf47d7c4fdff326ac1dccf6fff77e2357e6a2bd
---
M src/csn1.cpp
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/csn1.cpp b/src/csn1.cpp
index bf4d6c5..f248b95 100644
--- a/src/csn1.cpp
+++ b/src/csn1.cpp
@@ -1042,7 +1042,7 @@
         /*no break -
          * with a length set we have a regular variable length bitmap so we continue */
       }
-
+      /* FALL THROUGH */
       case CSN_VARIABLE_BITMAP:
       { /* {CSN_VARIABLE_BITMAP, 0, offsetof(_STRUCT, _ElementCountField), offsetof(_STRUCT, _MEMBER), #_MEMBER}
          * <N: bit (5)> <bitmap: bit(N + offset)>
@@ -1098,7 +1098,7 @@
          * with a length set we have a regular left aligned variable length bitmap so we continue
          */
       }
-
+      /* FALL THROUGH */
       case CSN_LEFT_ALIGNED_VAR_BMP:
       { /* {CSN_LEFT_ALIGNED_VAR_BMP, _OFFSET, (void*)offsetof(_STRUCT, _ElementCountField), offsetof(_STRUCT, _MEMBER), #_MEMBER}
          * <N: bit (5)> <bitmap: bit(N + offset)>
@@ -1321,7 +1321,7 @@
          * handling is exactly the same as for CSN_RECURSIVE_TARRAY_1 so we continue
          */
       }
-
+      /* FALL THROUGH */
       case CSN_RECURSIVE_TARRAY_1:
       { /* Recursive way to specify an array of type: <lists> ::= <type> { 1 <type> } ** 0 ;
          * M_REC_TARRAY(_STRUCT, _MEMBER, _MEMBER_TYPE, _ElementCountField)
@@ -2287,7 +2287,7 @@
         /*no break -
          * with a length set we have a regular variable length bitmap so we continue */
       }
-
+      /* FALL THROUGH */
       case CSN_VARIABLE_BITMAP:
       { /* {CSN_VARIABLE_BITMAP, 0, offsetof(_STRUCT, _ElementCountField), offsetof(_STRUCT, _MEMBER), #_MEMBER}
          * <N: bit (5)> <bitmap: bit(N + offset)>
@@ -2344,7 +2344,7 @@
          * with a length set we have a regular left aligned variable length bitmap so we continue
          */
       }
-
+      /* FALL THROUGH */
       case CSN_LEFT_ALIGNED_VAR_BMP:
       { /* {CSN_LEFT_ALIGNED_VAR_BMP, _OFFSET, (void*)offsetof(_STRUCT, _ElementCountField), offsetof(_STRUCT, _MEMBER), #_MEMBER}
          * <N: bit (5)> <bitmap: bit(N + offset)>
@@ -2573,7 +2573,7 @@
          * handling is exactly the same as for CSN_RECURSIVE_TARRAY_1 so we continue
          */
       }
-
+      /* FALL THROUGH */
       case CSN_RECURSIVE_TARRAY_1:
       { /* Recursive way to specify an array of type: <lists> ::= <type> { 1 <type> } ** 0 ;
          * M_REC_TARRAY(_STRUCT, _MEMBER, _MEMBER_TYPE, _ElementCountField)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17005
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ibaf47d7c4fdff326ac1dccf6fff77e2357e6a2bd
Gerrit-Change-Number: 17005
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200128/e7e76001/attachment.htm>


More information about the gerrit-log mailing list