<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17005">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">csn1: fix this statement may fall through [-Werror=implicit-fallthrough=] found by gcc7<br><br>Port of wireshark.git commit fd68c7dfc7d06ce7babe914f2575d9e4f35988ad.<br><br>Ported-by: Pau Espin Pedrol <pespin@sysmocom.de><br>Change-Id: Ibaf47d7c4fdff326ac1dccf6fff77e2357e6a2bd<br>---<br>M src/csn1.cpp<br>1 file changed, 6 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/csn1.cpp b/src/csn1.cpp</span><br><span>index bf4d6c5..f248b95 100644</span><br><span>--- a/src/csn1.cpp</span><br><span>+++ b/src/csn1.cpp</span><br><span>@@ -1042,7 +1042,7 @@</span><br><span>         /*no break -</span><br><span>          * with a length set we have a regular variable length bitmap so we continue */</span><br><span>       }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+      /* FALL THROUGH */</span><br><span>       case CSN_VARIABLE_BITMAP:</span><br><span>       { /* {CSN_VARIABLE_BITMAP, 0, offsetof(_STRUCT, _ElementCountField), offsetof(_STRUCT, _MEMBER), #_MEMBER}</span><br><span>          * <N: bit (5)> <bitmap: bit(N + offset)></span><br><span>@@ -1098,7 +1098,7 @@</span><br><span>          * with a length set we have a regular left aligned variable length bitmap so we continue</span><br><span>          */</span><br><span>       }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+      /* FALL THROUGH */</span><br><span>       case CSN_LEFT_ALIGNED_VAR_BMP:</span><br><span>       { /* {CSN_LEFT_ALIGNED_VAR_BMP, _OFFSET, (void*)offsetof(_STRUCT, _ElementCountField), offsetof(_STRUCT, _MEMBER), #_MEMBER}</span><br><span>          * <N: bit (5)> <bitmap: bit(N + offset)></span><br><span>@@ -1321,7 +1321,7 @@</span><br><span>          * handling is exactly the same as for CSN_RECURSIVE_TARRAY_1 so we continue</span><br><span>          */</span><br><span>       }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+      /* FALL THROUGH */</span><br><span>       case CSN_RECURSIVE_TARRAY_1:</span><br><span>       { /* Recursive way to specify an array of type: <lists> ::= <type> { 1 <type> } ** 0 ;</span><br><span>          * M_REC_TARRAY(_STRUCT, _MEMBER, _MEMBER_TYPE, _ElementCountField)</span><br><span>@@ -2287,7 +2287,7 @@</span><br><span>         /*no break -</span><br><span>          * with a length set we have a regular variable length bitmap so we continue */</span><br><span>       }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+      /* FALL THROUGH */</span><br><span>       case CSN_VARIABLE_BITMAP:</span><br><span>       { /* {CSN_VARIABLE_BITMAP, 0, offsetof(_STRUCT, _ElementCountField), offsetof(_STRUCT, _MEMBER), #_MEMBER}</span><br><span>          * <N: bit (5)> <bitmap: bit(N + offset)></span><br><span>@@ -2344,7 +2344,7 @@</span><br><span>          * with a length set we have a regular left aligned variable length bitmap so we continue</span><br><span>          */</span><br><span>       }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+      /* FALL THROUGH */</span><br><span>       case CSN_LEFT_ALIGNED_VAR_BMP:</span><br><span>       { /* {CSN_LEFT_ALIGNED_VAR_BMP, _OFFSET, (void*)offsetof(_STRUCT, _ElementCountField), offsetof(_STRUCT, _MEMBER), #_MEMBER}</span><br><span>          * <N: bit (5)> <bitmap: bit(N + offset)></span><br><span>@@ -2573,7 +2573,7 @@</span><br><span>          * handling is exactly the same as for CSN_RECURSIVE_TARRAY_1 so we continue</span><br><span>          */</span><br><span>       }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+      /* FALL THROUGH */</span><br><span>       case CSN_RECURSIVE_TARRAY_1:</span><br><span>       { /* Recursive way to specify an array of type: <lists> ::= <type> { 1 <type> } ** 0 ;</span><br><span>          * M_REC_TARRAY(_STRUCT, _MEMBER, _MEMBER_TYPE, _ElementCountField)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17005">change 17005</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/17005"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ibaf47d7c4fdff326ac1dccf6fff77e2357e6a2bd </div>
<div style="display:none"> Gerrit-Change-Number: 17005 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>