Change in libosmocore[master]: gprs_bssgp_rim: fix problem with uninitalized in bssgp_create_rim_ri()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Wed Dec 23 22:53:22 UTC 2020


dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/21864 )


Change subject: gprs_bssgp_rim: fix problem with uninitalized in bssgp_create_rim_ri()
......................................................................

gprs_bssgp_rim: fix problem with uninitalized in bssgp_create_rim_ri()

The variable raid_temp is used partially uninitalized since not all
possible members are set. The encoded end result will not
include any values from the uninitalized fields. However, lets ensure
that raid_temp is fully initalized in order to be clean.

Change-Id: Id92c3ae86016ef6000127fbef223276b250c2e97
Related: CID 215836
---
M src/gb/gprs_bssgp_rim.c
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/64/21864/1

diff --git a/src/gb/gprs_bssgp_rim.c b/src/gb/gprs_bssgp_rim.c
index c004b33..815b959 100644
--- a/src/gb/gprs_bssgp_rim.c
+++ b/src/gb/gprs_bssgp_rim.c
@@ -99,6 +99,7 @@
 		/* Note: 3GPP TS 24.301 Figure 9.9.3.32.1 and 3GPP TS 24.008
 		 * Figure 10.5.130 specify MCC/MNC encoding in the same way,
 		 * so we can re-use gsm48_encode_ra() for that. */
+		memset(&raid_temp, 0, sizeof(raid_temp));
 		raid_temp.mcc = ri->eutran.tai.mcc;
 		raid_temp.mnc = ri->eutran.tai.mnc;
 		raid_temp.mnc_3_digits = ri->eutran.tai.mnc_3_digits;

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21864
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id92c3ae86016ef6000127fbef223276b250c2e97
Gerrit-Change-Number: 21864
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201223/3c00fcad/attachment.htm>


More information about the gerrit-log mailing list