<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21864">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_bssgp_rim: fix problem with uninitalized in bssgp_create_rim_ri()<br><br>The variable raid_temp is used partially uninitalized since not all<br>possible members are set. The encoded end result will not<br>include any values from the uninitalized fields. However, lets ensure<br>that raid_temp is fully initalized in order to be clean.<br><br>Change-Id: Id92c3ae86016ef6000127fbef223276b250c2e97<br>Related: CID 215836<br>---<br>M src/gb/gprs_bssgp_rim.c<br>1 file changed, 1 insertion(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/64/21864/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_bssgp_rim.c b/src/gb/gprs_bssgp_rim.c</span><br><span>index c004b33..815b959 100644</span><br><span>--- a/src/gb/gprs_bssgp_rim.c</span><br><span>+++ b/src/gb/gprs_bssgp_rim.c</span><br><span>@@ -99,6 +99,7 @@</span><br><span>          /* Note: 3GPP TS 24.301 Figure 9.9.3.32.1 and 3GPP TS 24.008</span><br><span>                  * Figure 10.5.130 specify MCC/MNC encoding in the same way,</span><br><span>                  * so we can re-use gsm48_encode_ra() for that. */</span><br><span style="color: hsl(120, 100%, 40%);">+            memset(&raid_temp, 0, sizeof(raid_temp));</span><br><span>                raid_temp.mcc = ri->eutran.tai.mcc;</span><br><span>               raid_temp.mnc = ri->eutran.tai.mnc;</span><br><span>               raid_temp.mnc_3_digits = ri->eutran.tai.mnc_3_digits;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/21864">change 21864</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/21864"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id92c3ae86016ef6000127fbef223276b250c2e97 </div>
<div style="display:none"> Gerrit-Change-Number: 21864 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>