This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/21783 ) Change subject: Add per-line rate counter group to count various errors ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-e1d/+/21783/4/src/usb.c File src/usb.c: https://gerrit.osmocom.org/c/osmo-e1d/+/21783/4/src/usb.c@329 PS4, Line 329: if (errcnt->flags & ICE1USB_ERR_F_TICK_ERR) > I'm not entirely sure why you treat "Alignement" and "LOS" differently. […] I would have expected that alignment errors is something that can happen more often and ist more short-lived (basically alignment can be re-established quite quickly). Also, it's something you can actually count, as in 'how many frames with alignment errors did we see'. LOS on the other hand is something that I would expect to persist for a longer amount of time. Somebody disconnects a cable (intentionalyl or not). It's unlikely this would only happen for one or a hand ful of frames, but more like seconds, minutes, hours. We can of course change it, and I'm not saying I have a very firm opionion, just explaining my reasoning. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/21783 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I766b717843d7cd8ac00d4ce18c38773ac50ec3e6 Gerrit-Change-Number: 21783 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt <tnt at 246tNt.com> Gerrit-Comment-Date: Sun, 20 Dec 2020 10:33:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: tnt <tnt at 246tNt.com> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201220/8743de2f/attachment.htm>