Change in osmo-e1d[master]: Add per-line rate counter group to count various errors

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

tnt gerrit-no-reply at lists.osmocom.org
Sat Dec 19 20:26:13 UTC 2020


tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/21783 )

Change subject: Add per-line rate counter group to count various errors
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-e1d/+/21783/4/src/usb.c 
File src/usb.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/21783/4/src/usb.c@329 
PS4, Line 329: 		if (errcnt->flags & ICE1USB_ERR_F_TICK_ERR)
I'm not entirely sure why you treat "Alignement" and "LOS" differently.
Alignement gets both a counter and a flag while LOS only gets a Flag ? I mean they're both "status", I'm not really sure a device side counter for alignement makes sense.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/21783
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I766b717843d7cd8ac00d4ce18c38773ac50ec3e6
Gerrit-Change-Number: 21783
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Sat, 19 Dec 2020 20:26:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201219/ef189a74/attachment.htm>


More information about the gerrit-log mailing list