Change in osmo-e1-hardware[master]: icE1usb fw: Disable reporting of 'loss of timing' for now

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Dec 17 17:02:58 UTC 2020


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21778 )


Change subject: icE1usb fw: Disable reporting of 'loss of timing' for now
......................................................................

icE1usb fw: Disable reporting of 'loss of timing' for now

This works half way decent enough to make the LED status change visibly
in case the physical link is disconnected.  However, we will generate a
storm of USB interrupt endpoint messages if we leave this on

Change-Id: I9d0ddb2d404880c4a85e30de1b4bf4204d468ab7
---
M firmware/ice40-riscv/icE1usb/e1.c
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/78/21778/1

diff --git a/firmware/ice40-riscv/icE1usb/e1.c b/firmware/ice40-riscv/icE1usb/e1.c
index bf6fe9e..dda3016 100644
--- a/firmware/ice40-riscv/icE1usb/e1.c
+++ b/firmware/ice40-riscv/icE1usb/e1.c
@@ -378,7 +378,9 @@
 		uint16_t cur_tick = e1_tick_read_rx(0);
 		if (g_e1.rx.last_tick == cur_tick) {
 			e1_platform_led_set(0, E1P_LED_GREEN, E1P_LED_ST_OFF);
-			g_e1.errors.flags |= E1_ERR_F_TICK_ERR;
+			/* FIXME: this is very flaky, we are probably getting some noise
+			 * at the Rx tick counter if the cable is disconnected? */
+			//g_e1.errors.flags |= E1_ERR_F_TICK_ERR;
 		} else {
 			e1_platform_led_set(0, E1P_LED_GREEN, E1P_LED_ST_BLINK);
 			g_e1.errors.flags &= ~E1_ERR_F_TICK_ERR;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21778
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: I9d0ddb2d404880c4a85e30de1b4bf4204d468ab7
Gerrit-Change-Number: 21778
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201217/f0d14bdb/attachment.htm>


More information about the gerrit-log mailing list