<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21778">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">icE1usb fw: Disable reporting of 'loss of timing' for now<br><br>This works half way decent enough to make the LED status change visibly<br>in case the physical link is disconnected.  However, we will generate a<br>storm of USB interrupt endpoint messages if we leave this on<br><br>Change-Id: I9d0ddb2d404880c4a85e30de1b4bf4204d468ab7<br>---<br>M firmware/ice40-riscv/icE1usb/e1.c<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/78/21778/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/ice40-riscv/icE1usb/e1.c b/firmware/ice40-riscv/icE1usb/e1.c</span><br><span>index bf6fe9e..dda3016 100644</span><br><span>--- a/firmware/ice40-riscv/icE1usb/e1.c</span><br><span>+++ b/firmware/ice40-riscv/icE1usb/e1.c</span><br><span>@@ -378,7 +378,9 @@</span><br><span>              uint16_t cur_tick = e1_tick_read_rx(0);</span><br><span>              if (g_e1.rx.last_tick == cur_tick) {</span><br><span>                         e1_platform_led_set(0, E1P_LED_GREEN, E1P_LED_ST_OFF);</span><br><span style="color: hsl(0, 100%, 40%);">-                  g_e1.errors.flags |= E1_ERR_F_TICK_ERR;</span><br><span style="color: hsl(120, 100%, 40%);">+                       /* FIXME: this is very flaky, we are probably getting some noise</span><br><span style="color: hsl(120, 100%, 40%);">+                       * at the Rx tick counter if the cable is disconnected? */</span><br><span style="color: hsl(120, 100%, 40%);">+                    //g_e1.errors.flags |= E1_ERR_F_TICK_ERR;</span><br><span>            } else {</span><br><span>                     e1_platform_led_set(0, E1P_LED_GREEN, E1P_LED_ST_BLINK);</span><br><span>                     g_e1.errors.flags &= ~E1_ERR_F_TICK_ERR;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21778">change 21778</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21778"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-e1-hardware </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9d0ddb2d404880c4a85e30de1b4bf4204d468ab7 </div>
<div style="display:none"> Gerrit-Change-Number: 21778 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>