Change in osmo-bsc[master]: handover_fsm: signal Clear from gscon, for proper HO result counts

[neels]

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19900 )

Change subject: handover_fsm: signal Clear from gscon, for proper HO result counts
......................................................................

handover_fsm: signal Clear from gscon, for proper HO result counts

An inter-BSC-OUT handover ends with a Clear Command, which HO_OUT_ST_WAIT_CLEAR
waits for. Actually tell the handover_fsm.c about an incoming Clear Command, so
that the inter-BSC-OUT success can be counted.

Similarly, count failing handover results for an unexpected Clear Command from
the MSC.

Related: OS#4736
Change-Id: I0c489838a99f930e2104619ca745191d2a736f1b
---
M src/osmo-bsc/bsc_subscr_conn_fsm.c
M src/osmo-bsc/handover_fsm.c
2 files changed, 7 insertions(+), 0 deletions(-)

Approvals:
  neels: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c
index e7c6efe..b6ea59f 100644
--- a/src/osmo-bsc/bsc_subscr_conn_fsm.c
+++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c
@@ -771,6 +771,11 @@
 	case GSCON_EV_A_CLEAR_CMD:
 		conn->rx_clear_command = true;
 
+		/* Give the handover_fsm a chance to book this as handover success before tearing down everything,
+		 * making it look like a sudden death failure. */
+		if (conn->ho.fi)
+			osmo_fsm_inst_dispatch(conn->ho.fi, HO_EV_CONN_RELEASING, NULL);
+
 		OSMO_ASSERT(data);
 		ccd = data;
 		if (conn->lchan)
diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c
index d93e5bc..8e231e0 100644
--- a/src/osmo-bsc/handover_fsm.c
+++ b/src/osmo-bsc/handover_fsm.c
@@ -1269,6 +1269,8 @@
 {
 	struct gsm_subscriber_connection *conn = ho_fi_conn(fi);
 	switch (event) {
+		/* See also ho_fsm_allstate_action() for ho_success() on HO_EV_CONN_RELEASING */
+
 	case HO_EV_RR_HO_FAIL:
 		ho_fail(HO_RESULT_FAIL_RR_HO_FAIL, "Received RR Handover Failure message");
 		return;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19900
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I0c489838a99f930e2104619ca745191d2a736f1b
Gerrit-Change-Number: 19900
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200831/bb53f69a/attachment.htm>