<p>neels <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19900">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  neels: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">handover_fsm: signal Clear from gscon, for proper HO result counts<br><br>An inter-BSC-OUT handover ends with a Clear Command, which HO_OUT_ST_WAIT_CLEAR<br>waits for. Actually tell the handover_fsm.c about an incoming Clear Command, so<br>that the inter-BSC-OUT success can be counted.<br><br>Similarly, count failing handover results for an unexpected Clear Command from<br>the MSC.<br><br>Related: OS#4736<br>Change-Id: I0c489838a99f930e2104619ca745191d2a736f1b<br>---<br>M src/osmo-bsc/bsc_subscr_conn_fsm.c<br>M src/osmo-bsc/handover_fsm.c<br>2 files changed, 7 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c</span><br><span>index e7c6efe..b6ea59f 100644</span><br><span>--- a/src/osmo-bsc/bsc_subscr_conn_fsm.c</span><br><span>+++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c</span><br><span>@@ -771,6 +771,11 @@</span><br><span>        case GSCON_EV_A_CLEAR_CMD:</span><br><span>           conn->rx_clear_command = true;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+         /* Give the handover_fsm a chance to book this as handover success before tearing down everything,</span><br><span style="color: hsl(120, 100%, 40%);">+             * making it look like a sudden death failure. */</span><br><span style="color: hsl(120, 100%, 40%);">+             if (conn->ho.fi)</span><br><span style="color: hsl(120, 100%, 40%);">+                   osmo_fsm_inst_dispatch(conn->ho.fi, HO_EV_CONN_RELEASING, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>                OSMO_ASSERT(data);</span><br><span>           ccd = data;</span><br><span>          if (conn->lchan)</span><br><span>diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c</span><br><span>index d93e5bc..8e231e0 100644</span><br><span>--- a/src/osmo-bsc/handover_fsm.c</span><br><span>+++ b/src/osmo-bsc/handover_fsm.c</span><br><span>@@ -1269,6 +1269,8 @@</span><br><span> {</span><br><span>    struct gsm_subscriber_connection *conn = ho_fi_conn(fi);</span><br><span>     switch (event) {</span><br><span style="color: hsl(120, 100%, 40%);">+              /* See also ho_fsm_allstate_action() for ho_success() on HO_EV_CONN_RELEASING */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>   case HO_EV_RR_HO_FAIL:</span><br><span>               ho_fail(HO_RESULT_FAIL_RR_HO_FAIL, "Received RR Handover Failure message");</span><br><span>                return;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19900">change 19900</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/19900"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0c489838a99f930e2104619ca745191d2a736f1b </div>
<div style="display:none"> Gerrit-Change-Number: 19900 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>