Change in osmo-trx[master]: osmo-trx-ipc

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/19641 )

Change subject: osmo-trx-ipc
......................................................................


Patch Set 2:

(7 comments)

https://gerrit.osmocom.org/c/osmo-trx/+/19641/2/Transceiver52M/device/ipc/ipc-driver-test.c 
File Transceiver52M/device/ipc/ipc-driver-test.c:

https://gerrit.osmocom.org/c/osmo-trx/+/19641/2/Transceiver52M/device/ipc/ipc-driver-test.c@72 
PS2, Line 72: 	[DMAIN] = {
Inconsistent formatting.


https://gerrit.osmocom.org/c/osmo-trx/+/19641/2/Transceiver52M/device/ipc/ipc-driver-test.c@74 
PS2, Line 74: color
Why three tabs here?


https://gerrit.osmocom.org/c/osmo-trx/+/19641/2/Transceiver52M/device/ipc/ipc-driver-test.c@240 
PS2, Line 240:      *
formatting


https://gerrit.osmocom.org/c/osmo-trx/+/19641/2/Transceiver52M/device/ipc/ipc_chan.c 
File Transceiver52M/device/ipc/ipc_chan.c:

https://gerrit.osmocom.org/c/osmo-trx/+/19641/2/Transceiver52M/device/ipc/ipc_chan.c@7 
PS2, Line 7:     Permission to use, copy, modify, and/or distribute this software for any purpose with or without fee is hereby granted.
The formatting of this header is inconsistent compared to the other license headers introduced by this change. In some files 4 spaces are used as spacing, in others they are absent. The usual approach is ' * TEXT'.


https://gerrit.osmocom.org/c/osmo-trx/+/19641/2/Transceiver52M/device/ipc/ipc_chan.c@50 
PS2, Line 50: %d
chan_nr is unsigned, so %u


https://gerrit.osmocom.org/c/osmo-trx/+/19641/2/Transceiver52M/device/ipc/ipc_chan.c@54 
PS2, Line 54: fprintf
BTW, why not LOGP()?


https://gerrit.osmocom.org/c/osmo-trx/+/19641/2/Transceiver52M/device/ipc/ipc_chan.c@134 
PS2, Line 134: LOGP(DMAIN, LOGL_INFO,
             : 		     "IPC socket not created, "
             : 		     "dropping message\n");
Is it how clang-format formats the code? Looks very odd, I am sure it would take less than 120 chars...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/19641
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ice63d3499026293ade8aad675ff7a883bcdd5756
Gerrit-Change-Number: 19641
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 14 Aug 2020 08:46:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200814/191be6ed/attachment.htm>