<p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/19641">View Change</a></p><p>7 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/19641/2/Transceiver52M/device/ipc/ipc-driver-test.c">File Transceiver52M/device/ipc/ipc-driver-test.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-trx/+/19641/2/Transceiver52M/device/ipc/ipc-driver-test.c@72">Patch Set #2, Line 72:</a> <code style="font-family:monospace,monospace"> [DMAIN] = {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Inconsistent formatting.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-trx/+/19641/2/Transceiver52M/device/ipc/ipc-driver-test.c@74">Patch Set #2, Line 74:</a> <code style="font-family:monospace,monospace">color</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why three tabs here?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-trx/+/19641/2/Transceiver52M/device/ipc/ipc-driver-test.c@240">Patch Set #2, Line 240:</a> <code style="font-family:monospace,monospace"> *</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">formatting</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/19641/2/Transceiver52M/device/ipc/ipc_chan.c">File Transceiver52M/device/ipc/ipc_chan.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-trx/+/19641/2/Transceiver52M/device/ipc/ipc_chan.c@7">Patch Set #2, Line 7:</a> <code style="font-family:monospace,monospace"> Permission to use, copy, modify, and/or distribute this software for any purpose with or without fee is hereby granted.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">The formatting of this header is inconsistent compared to the other license headers introduced by this change. In some files 4 spaces are used as spacing, in others they are absent. The usual approach is ' * TEXT'.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-trx/+/19641/2/Transceiver52M/device/ipc/ipc_chan.c@50">Patch Set #2, Line 50:</a> <code style="font-family:monospace,monospace">%d</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">chan_nr is unsigned, so %u</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-trx/+/19641/2/Transceiver52M/device/ipc/ipc_chan.c@54">Patch Set #2, Line 54:</a> <code style="font-family:monospace,monospace">fprintf</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">BTW, why not LOGP()?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-trx/+/19641/2/Transceiver52M/device/ipc/ipc_chan.c@134">Patch Set #2, Line 134:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">LOGP(DMAIN, LOGL_INFO,<br> "IPC socket not created, "<br> "dropping message\n");<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Is it how clang-format formats the code? Looks very odd, I am sure it would take less than 120 chars...</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/19641">change 19641</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/19641"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ice63d3499026293ade8aad675ff7a883bcdd5756 </div>
<div style="display:none"> Gerrit-Change-Number: 19641 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 14 Aug 2020 08:46:25 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>