This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18702 ) Change subject: timeslot_fsm: Name TS FSM instances on allocation. ...................................................................... timeslot_fsm: Name TS FSM instances on allocation. Before this patch FSM instances of configured but not connected BTS's look like this: FSM Instance Name: 'timeslot[0x612000004a20]', ID: '(null)' Log-Level: 'DEBUG', State: 'NOT_INITIALIZED' Now they look like this: FSM Instance Name: 'timeslot(0-0-7-NONE)[0x612000004a20]', ID: '0-0-7-NONE' Log-Level: 'DEBUG', State: 'NOT_INITIALIZED' which makes it possible to attribute them to where they belong. Otherwise, they look like lingering or leaking unattributed FSM instances. Change-Id: Idc74ea142b96323b48826f8a52e13e45d535512a --- M src/osmo-bsc/timeslot_fsm.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/timeslot_fsm.c b/src/osmo-bsc/timeslot_fsm.c index 0aecfae..106e6a1 100644 --- a/src/osmo-bsc/timeslot_fsm.c +++ b/src/osmo-bsc/timeslot_fsm.c @@ -63,6 +63,7 @@ OSMO_ASSERT(ts->trx); ts->fi = osmo_fsm_inst_alloc(&ts_fsm, ts->trx, ts, LOGL_DEBUG, NULL); OSMO_ASSERT(ts->fi); + ts_fsm_update_id(ts); } enum lchan_sanity { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18702 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idc74ea142b96323b48826f8a52e13e45d535512a Gerrit-Change-Number: 18702 Gerrit-PatchSet: 2 Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200812/c451a73d/attachment.htm>