<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18702">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">timeslot_fsm: Name TS FSM instances on allocation.<br><br>Before this patch FSM instances of configured but not connected BTS's<br>look like this:<br>FSM Instance Name: 'timeslot[0x612000004a20]', ID: '(null)'<br> Log-Level: 'DEBUG', State: 'NOT_INITIALIZED'<br><br>Now they look like this:<br>FSM Instance Name: 'timeslot(0-0-7-NONE)[0x612000004a20]', ID: '0-0-7-NONE'<br> Log-Level: 'DEBUG', State: 'NOT_INITIALIZED'<br><br>which makes it possible to attribute them to where they belong.<br>Otherwise, they look like lingering or leaking unattributed FSM<br>instances.<br><br>Change-Id: Idc74ea142b96323b48826f8a52e13e45d535512a<br>---<br>M src/osmo-bsc/timeslot_fsm.c<br>1 file changed, 1 insertion(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/timeslot_fsm.c b/src/osmo-bsc/timeslot_fsm.c</span><br><span>index 0aecfae..106e6a1 100644</span><br><span>--- a/src/osmo-bsc/timeslot_fsm.c</span><br><span>+++ b/src/osmo-bsc/timeslot_fsm.c</span><br><span>@@ -63,6 +63,7 @@</span><br><span>       OSMO_ASSERT(ts->trx);</span><br><span>     ts->fi = osmo_fsm_inst_alloc(&ts_fsm, ts->trx, ts, LOGL_DEBUG, NULL);</span><br><span>      OSMO_ASSERT(ts->fi);</span><br><span style="color: hsl(120, 100%, 40%);">+       ts_fsm_update_id(ts);</span><br><span> }</span><br><span> </span><br><span> enum lchan_sanity {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18702">change 18702</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/18702"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Idc74ea142b96323b48826f8a52e13e45d535512a </div>
<div style="display:none"> Gerrit-Change-Number: 18702 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: ipse <Alexander.Chemeris@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>