This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17593 ) Change subject: mobile: add audio config, with unused audio loopback setting ...................................................................... Patch Set 2: (4 comments) https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/doc/examples/mobile/multi_ms.cfg File doc/examples/mobile/multi_ms.cfg: https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/doc/examples/mobile/multi_ms.cfg@63 PS2, Line 63: io-target none > Fine with me, but since this isn't my patch: […] take a look at vadim's audio patch: that is all about redirecting audio to a file, to a local sound card etc. Setting it to loopback is added there by this patch (or rather, this patch does some of the preparations for vadim's patch already). Maybe just "target" then, but I don't mind "io-target". https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/src/host/layer23/src/mobile/vty_interface.c File src/host/layer23/src/mobile/vty_interface.c: https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/src/host/layer23/src/mobile/vty_interface.c@1538 PS2, Line 1538: vty_out(vty, " no io-target%s", VTY_NEWLINE); > > why there's a "no"? simply have io-target none. […] the most widespread vty pattern in osmocom to switch something off is no foo obviously we should stick to that pattern. Vadim's original patch also has a 'no io-target'. Whether or not to omit default behavior in vty write is varied in osmo programs. Seems that recent developments favor omitting default behavior, but that isn't always helping the user to understand. Personally, I slightly favor printing the defaults. Interesting, the hide_default is a static global that defaults to 0 (i.e. print the defaults) and can be changed by the vty command 'hide-default' :) https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/src/host/layer23/src/mobile/vty_interface.c@2776 PS2, Line 2776: argv[0] > Now I'm sure: argv[0] can't be used here, because the config string "io-target loopback" doesn't tak […] thx! Came from copying code with multiple args and reducing it to one https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/src/host/layer23/src/mobile/vty_interface.c@2780 PS2, Line 2780: "no io-target", NO_STR "Disable TCH frame processing") > You can drop this one, rather have a io-target none disagree -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17593 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie03e4a6c6f81ea3925266dd22e87506d722a6e1a Gerrit-Change-Number: 17593 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 30 Apr 2020 12:42:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: osmith <osmith at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200430/3667ea83/attachment.htm>