<p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/17593">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/doc/examples/mobile/multi_ms.cfg">File doc/examples/mobile/multi_ms.cfg:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/doc/examples/mobile/multi_ms.cfg@63">Patch Set #2, Line 63:</a> <code style="font-family:monospace,monospace"> io-target none</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Fine with me, but since this isn't my patch: […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">take a look at vadim's audio patch: that is all about redirecting audio to a file, to a local sound card etc. Setting it to loopback is added there by this patch (or rather, this patch does some of the preparations for vadim's patch already). Maybe just "target" then, but I don't mind "io-target".</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/src/host/layer23/src/mobile/vty_interface.c">File src/host/layer23/src/mobile/vty_interface.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/src/host/layer23/src/mobile/vty_interface.c@1538">Patch Set #2, Line 1538:</a> <code style="font-family:monospace,monospace"> vty_out(vty, " no io-target%s", VTY_NEWLINE);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">> why there's a "no"? simply have io-target none. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">the most widespread vty pattern in osmocom to switch something off is</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> no foo</pre><p style="white-space: pre-wrap; word-wrap: break-word;">obviously we should stick to that pattern.<br>Vadim's original patch also has a 'no io-target'.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Whether or not to omit default behavior in vty write is varied in osmo programs.<br>Seems that recent developments favor omitting default behavior, but that isn't always helping the user to understand. Personally, I slightly favor printing the defaults.<br>Interesting, the hide_default is a static global that defaults to 0 (i.e. print the defaults) and can be changed by the vty command 'hide-default' :)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/src/host/layer23/src/mobile/vty_interface.c@2776">Patch Set #2, Line 2776:</a> <code style="font-family:monospace,monospace">argv[0]</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Now I'm sure: argv[0] can't be used here, because the config string "io-target loopback" doesn't tak […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">thx! Came from copying code with multiple args and reducing it to one</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/17593/2/src/host/layer23/src/mobile/vty_interface.c@2780">Patch Set #2, Line 2780:</a> <code style="font-family:monospace,monospace"> "no io-target", NO_STR "Disable TCH frame processing")</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">You can drop this one, rather have a io-target none</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">disagree</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmocom-bb/+/17593">change 17593</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmocom-bb/+/17593"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie03e4a6c6f81ea3925266dd22e87506d722a6e1a </div>
<div style="display:none"> Gerrit-Change-Number: 17593 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 30 Apr 2020 12:42:09 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Comment-In-Reply-To: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>