Change in osmo-bts[master]: osmo-bts-{sysmo, oc2g, lc15}: fix segfault on 'dsp-trace-flag'

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17946 )

Change subject: osmo-bts-{sysmo,oc2g,lc15}: fix segfault on 'dsp-trace-flag'
......................................................................

osmo-bts-{sysmo,oc2g,lc15}: fix segfault on 'dsp-trace-flag'

== How to reproduce?

  phy 0
    instance 0
      dsp-trace-flag error
      dsp-trace-flag debug

== What happens?

  Program received signal SIGSEGV, Segmentation fault.
  0x432dbe64 in strcasecmp () from /lib/libc.so.6
  (gdb)
  (gdb) bt
  #00x432dbe64 in strcasecmp () from /lib/libc.so.6
  #10xb6ed69ec in get_string_value () from /usr/lib/libosmocore.so.12
  #20x0001bcf0 in cfg_phy_dsp_trace_f ()
  #30xb6fc1080 in ?? () from /usr/lib/libosmovty.so.4
  Backtrace stopped: previous frame identical to this frame (corrupt stack?)

Change-Id: I23137930f81bfa8adbb62828f341470c11202b5e
---
M src/osmo-bts-litecell15/lc15bts_vty.c
M src/osmo-bts-oc2g/oc2gbts_vty.c
M src/osmo-bts-sysmo/sysmobts_vty.c
3 files changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/osmo-bts-litecell15/lc15bts_vty.c b/src/osmo-bts-litecell15/lc15bts_vty.c
index 944cfd5..3643a92 100644
--- a/src/osmo-bts-litecell15/lc15bts_vty.c
+++ b/src/osmo-bts-litecell15/lc15bts_vty.c
@@ -120,7 +120,7 @@
 	struct phy_instance *pinst = vty->index;
 	unsigned int flag;
 
-	flag = get_string_value(lc15bts_tracef_names, argv[1]);
+	flag = get_string_value(lc15bts_tracef_names, argv[0]);
 	pinst->u.lc15.dsp_trace_f |= flag;
 
 	return CMD_SUCCESS;
@@ -132,7 +132,7 @@
 	struct phy_instance *pinst = vty->index;
 	unsigned int flag;
 
-	flag = get_string_value(lc15bts_tracef_names, argv[1]);
+	flag = get_string_value(lc15bts_tracef_names, argv[0]);
 	pinst->u.lc15.dsp_trace_f &= ~flag;
 
 	return CMD_SUCCESS;
diff --git a/src/osmo-bts-oc2g/oc2gbts_vty.c b/src/osmo-bts-oc2g/oc2gbts_vty.c
index 1f092dd..ecbd797 100644
--- a/src/osmo-bts-oc2g/oc2gbts_vty.c
+++ b/src/osmo-bts-oc2g/oc2gbts_vty.c
@@ -113,7 +113,7 @@
 	struct phy_instance *pinst = vty->index;
 	unsigned int flag;
 
-	flag = get_string_value(oc2gbts_tracef_names, argv[1]);
+	flag = get_string_value(oc2gbts_tracef_names, argv[0]);
 	pinst->u.oc2g.dsp_trace_f |= flag;
 
 	return CMD_SUCCESS;
@@ -125,7 +125,7 @@
 	struct phy_instance *pinst = vty->index;
 	unsigned int flag;
 
-	flag = get_string_value(oc2gbts_tracef_names, argv[1]);
+	flag = get_string_value(oc2gbts_tracef_names, argv[0]);
 	pinst->u.oc2g.dsp_trace_f &= ~flag;
 
 	return CMD_SUCCESS;
diff --git a/src/osmo-bts-sysmo/sysmobts_vty.c b/src/osmo-bts-sysmo/sysmobts_vty.c
index 3199c8e..23f69a0 100644
--- a/src/osmo-bts-sysmo/sysmobts_vty.c
+++ b/src/osmo-bts-sysmo/sysmobts_vty.c
@@ -178,7 +178,7 @@
 	struct phy_instance *pinst = vty->index;
 	unsigned int flag;
 
-	flag = get_string_value(femtobts_tracef_names, argv[1]);
+	flag = get_string_value(femtobts_tracef_names, argv[0]);
 	pinst->u.sysmobts.dsp_trace_f |= flag;
 
 	return CMD_SUCCESS;
@@ -190,7 +190,7 @@
 	struct phy_instance *pinst = vty->index;
 	unsigned int flag;
 
-	flag = get_string_value(femtobts_tracef_names, argv[1]);
+	flag = get_string_value(femtobts_tracef_names, argv[0]);
 	pinst->u.sysmobts.dsp_trace_f &= ~flag;
 
 	return CMD_SUCCESS;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17946
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I23137930f81bfa8adbb62828f341470c11202b5e
Gerrit-Change-Number: 17946
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200426/a8a12b03/attachment.htm>