<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/17946">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo-bts-{sysmo,oc2g,lc15}: fix segfault on 'dsp-trace-flag'<br><br>== How to reproduce?<br><br>  phy 0<br>    instance 0<br>      dsp-trace-flag error<br>      dsp-trace-flag debug<br><br>== What happens?<br><br>  Program received signal SIGSEGV, Segmentation fault.<br>  0x432dbe64 in strcasecmp () from /lib/libc.so.6<br>  (gdb)<br>  (gdb) bt<br>  #00x432dbe64 in strcasecmp () from /lib/libc.so.6<br>  #10xb6ed69ec in get_string_value () from /usr/lib/libosmocore.so.12<br>  #20x0001bcf0 in cfg_phy_dsp_trace_f ()<br>  #30xb6fc1080 in ?? () from /usr/lib/libosmovty.so.4<br>  Backtrace stopped: previous frame identical to this frame (corrupt stack?)<br><br>Change-Id: I23137930f81bfa8adbb62828f341470c11202b5e<br>---<br>M src/osmo-bts-litecell15/lc15bts_vty.c<br>M src/osmo-bts-oc2g/oc2gbts_vty.c<br>M src/osmo-bts-sysmo/sysmobts_vty.c<br>3 files changed, 6 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-litecell15/lc15bts_vty.c b/src/osmo-bts-litecell15/lc15bts_vty.c</span><br><span>index 944cfd5..3643a92 100644</span><br><span>--- a/src/osmo-bts-litecell15/lc15bts_vty.c</span><br><span>+++ b/src/osmo-bts-litecell15/lc15bts_vty.c</span><br><span>@@ -120,7 +120,7 @@</span><br><span>     struct phy_instance *pinst = vty->index;</span><br><span>  unsigned int flag;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  flag = get_string_value(lc15bts_tracef_names, argv[1]);</span><br><span style="color: hsl(120, 100%, 40%);">+       flag = get_string_value(lc15bts_tracef_names, argv[0]);</span><br><span>      pinst->u.lc15.dsp_trace_f |= flag;</span><br><span> </span><br><span>    return CMD_SUCCESS;</span><br><span>@@ -132,7 +132,7 @@</span><br><span>    struct phy_instance *pinst = vty->index;</span><br><span>  unsigned int flag;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  flag = get_string_value(lc15bts_tracef_names, argv[1]);</span><br><span style="color: hsl(120, 100%, 40%);">+       flag = get_string_value(lc15bts_tracef_names, argv[0]);</span><br><span>      pinst->u.lc15.dsp_trace_f &= ~flag;</span><br><span> </span><br><span>       return CMD_SUCCESS;</span><br><span>diff --git a/src/osmo-bts-oc2g/oc2gbts_vty.c b/src/osmo-bts-oc2g/oc2gbts_vty.c</span><br><span>index 1f092dd..ecbd797 100644</span><br><span>--- a/src/osmo-bts-oc2g/oc2gbts_vty.c</span><br><span>+++ b/src/osmo-bts-oc2g/oc2gbts_vty.c</span><br><span>@@ -113,7 +113,7 @@</span><br><span>   struct phy_instance *pinst = vty->index;</span><br><span>  unsigned int flag;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  flag = get_string_value(oc2gbts_tracef_names, argv[1]);</span><br><span style="color: hsl(120, 100%, 40%);">+       flag = get_string_value(oc2gbts_tracef_names, argv[0]);</span><br><span>      pinst->u.oc2g.dsp_trace_f |= flag;</span><br><span> </span><br><span>    return CMD_SUCCESS;</span><br><span>@@ -125,7 +125,7 @@</span><br><span>    struct phy_instance *pinst = vty->index;</span><br><span>  unsigned int flag;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  flag = get_string_value(oc2gbts_tracef_names, argv[1]);</span><br><span style="color: hsl(120, 100%, 40%);">+       flag = get_string_value(oc2gbts_tracef_names, argv[0]);</span><br><span>      pinst->u.oc2g.dsp_trace_f &= ~flag;</span><br><span> </span><br><span>       return CMD_SUCCESS;</span><br><span>diff --git a/src/osmo-bts-sysmo/sysmobts_vty.c b/src/osmo-bts-sysmo/sysmobts_vty.c</span><br><span>index 3199c8e..23f69a0 100644</span><br><span>--- a/src/osmo-bts-sysmo/sysmobts_vty.c</span><br><span>+++ b/src/osmo-bts-sysmo/sysmobts_vty.c</span><br><span>@@ -178,7 +178,7 @@</span><br><span>   struct phy_instance *pinst = vty->index;</span><br><span>  unsigned int flag;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  flag = get_string_value(femtobts_tracef_names, argv[1]);</span><br><span style="color: hsl(120, 100%, 40%);">+      flag = get_string_value(femtobts_tracef_names, argv[0]);</span><br><span>     pinst->u.sysmobts.dsp_trace_f |= flag;</span><br><span> </span><br><span>        return CMD_SUCCESS;</span><br><span>@@ -190,7 +190,7 @@</span><br><span>    struct phy_instance *pinst = vty->index;</span><br><span>  unsigned int flag;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  flag = get_string_value(femtobts_tracef_names, argv[1]);</span><br><span style="color: hsl(120, 100%, 40%);">+      flag = get_string_value(femtobts_tracef_names, argv[0]);</span><br><span>     pinst->u.sysmobts.dsp_trace_f &= ~flag;</span><br><span> </span><br><span>   return CMD_SUCCESS;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/17946">change 17946</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/17946"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I23137930f81bfa8adbb62828f341470c11202b5e </div>
<div style="display:none"> Gerrit-Change-Number: 17946 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>