Change in ...osmo-trx[master]: Transceiver: Fixed copying of history into and from channelizer buffer.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

timojacobus gerrit-no-reply at lists.osmocom.org
Thu Sep 5 10:13:52 UTC 2019


timojacobus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/15413


Change subject: Transceiver: Fixed copying of history into and from channelizer buffer.
......................................................................

Transceiver: Fixed copying of history into and from channelizer buffer.

In multi arfcn mode, osmo-trx would drop some bursts because it couldn't detect it
and would emit idle burst instead. Specificaly detection of peak in correlation
vector failed. Correcting copying of history in pullBuffer method fixes this issue.

Change-Id: I93e43f6868cd67e69fc59d2980a03550d2505bf8
---
M Transceiver52M/radioInterfaceMulti.cpp
1 file changed, 4 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/13/15413/1

diff --git a/Transceiver52M/radioInterfaceMulti.cpp b/Transceiver52M/radioInterfaceMulti.cpp
index 0208e82..02762ac 100644
--- a/Transceiver52M/radioInterfaceMulti.cpp
+++ b/Transceiver52M/radioInterfaceMulti.cpp
@@ -278,19 +278,12 @@
 		size_t hLen = dnsampler->len();
 
 		float *fdst = &buf[2 * -hLen];
-		complex *src = history[lchan]->begin();
-		for (i = 0; i < hLen; i++) {
-			fdst[0] = src->real();
-			fdst[1] = src->imag();
-			src++;
-			fdst += 2;
-		}
-		complex *dst = history[lchan]->begin();
+		complex *hist = history[lchan]->begin();
 		float *fsrc = &buf[2 * (cLen - hLen)];
 		for (i = 0; i < hLen; i++) {
-			*dst = complex(fdst[0], fdst[1]);
-			fsrc += 2;
-			dst++;
+			fdst[2*i] = hist[i].real();
+			fdst[2*i+1] = hist[i].imag();
+			hist[i] = complex(fsrc[2*i], fsrc[2*i+1]);
 		}
 
 		float *wr_segment = recvBuffer[lchan]->getWriteSegment();

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15413
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I93e43f6868cd67e69fc59d2980a03550d2505bf8
Gerrit-Change-Number: 15413
Gerrit-PatchSet: 1
Gerrit-Owner: timojacobus <timojacobus5 at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190905/1cb7b086/attachment.htm>


More information about the gerrit-log mailing list