<p>timojacobus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/15413">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Transceiver: Fixed copying of history into and from channelizer buffer.<br><br>In multi arfcn mode, osmo-trx would drop some bursts because it couldn't detect it<br>and would emit idle burst instead. Specificaly detection of peak in correlation<br>vector failed. Correcting copying of history in pullBuffer method fixes this issue.<br><br>Change-Id: I93e43f6868cd67e69fc59d2980a03550d2505bf8<br>---<br>M Transceiver52M/radioInterfaceMulti.cpp<br>1 file changed, 4 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/13/15413/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/radioInterfaceMulti.cpp b/Transceiver52M/radioInterfaceMulti.cpp</span><br><span>index 0208e82..02762ac 100644</span><br><span>--- a/Transceiver52M/radioInterfaceMulti.cpp</span><br><span>+++ b/Transceiver52M/radioInterfaceMulti.cpp</span><br><span>@@ -278,19 +278,12 @@</span><br><span>                 size_t hLen = dnsampler->len();</span><br><span> </span><br><span>               float *fdst = &buf[2 * -hLen];</span><br><span style="color: hsl(0, 100%, 40%);">-              complex *src = history[lchan]->begin();</span><br><span style="color: hsl(0, 100%, 40%);">-              for (i = 0; i < hLen; i++) {</span><br><span style="color: hsl(0, 100%, 40%);">-                 fdst[0] = src->real();</span><br><span style="color: hsl(0, 100%, 40%);">-                       fdst[1] = src->imag();</span><br><span style="color: hsl(0, 100%, 40%);">-                       src++;</span><br><span style="color: hsl(0, 100%, 40%);">-                  fdst += 2;</span><br><span style="color: hsl(0, 100%, 40%);">-              }</span><br><span style="color: hsl(0, 100%, 40%);">-               complex *dst = history[lchan]->begin();</span><br><span style="color: hsl(120, 100%, 40%);">+            complex *hist = history[lchan]->begin();</span><br><span>          float *fsrc = &buf[2 * (cLen - hLen)];</span><br><span>           for (i = 0; i < hLen; i++) {</span><br><span style="color: hsl(0, 100%, 40%);">-                 *dst = complex(fdst[0], fdst[1]);</span><br><span style="color: hsl(0, 100%, 40%);">-                       fsrc += 2;</span><br><span style="color: hsl(0, 100%, 40%);">-                      dst++;</span><br><span style="color: hsl(120, 100%, 40%);">+                        fdst[2*i] = hist[i].real();</span><br><span style="color: hsl(120, 100%, 40%);">+                   fdst[2*i+1] = hist[i].imag();</span><br><span style="color: hsl(120, 100%, 40%);">+                 hist[i] = complex(fsrc[2*i], fsrc[2*i+1]);</span><br><span>           }</span><br><span> </span><br><span>                float *wr_segment = recvBuffer[lchan]->getWriteSegment();</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/15413">change 15413</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/15413"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I93e43f6868cd67e69fc59d2980a03550d2505bf8 </div>
<div style="display:none"> Gerrit-Change-Number: 15413 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: timojacobus <timojacobus5@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>