This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
daniel gerrit-no-reply at lists.osmocom.orgdaniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15719 ) Change subject: gsm0508: add functions to calculate beginning of a block ...................................................................... Patch Set 5: Code-Review+1 (3 comments) https://gerrit.osmocom.org/c/libosmocore/+/15719/5/src/gsm/gsm0502.c File src/gsm/gsm0502.c: https://gerrit.osmocom.org/c/libosmocore/+/15719/5/src/gsm/gsm0502.c@51 PS5, Line 51: /* Section 7 Table 1 of 5 Mapping of logical channels onto physical channels */ In newer specs it seems to be called "Clause 7 [...]". And unfortunately it's not even in the ToC of the spec...just some pages stuffed in there between the regular chapter and the appendix. I think renaming this to Section/Clause 7 would be good so a text search can yield results. https://gerrit.osmocom.org/c/libosmocore/+/15719/5/src/gsm/gsm0502.c@117 PS5, Line 117: Section Section/Clause https://gerrit.osmocom.org/c/libosmocore/+/15719/5/src/gsm/gsm0502.c@124 PS5, Line 124: #define fn_remap_table_from_traffic_block_map(table, map, rows, cols, repeat) \ I think it would be okay to just add the tables that you are calculating in the initializer and macro to the source. Although I also like that the structs directly contain the info from the spec... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15719 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3d71c66f8c401f5afbad9b1c86c24580dab9e0ce Gerrit-Change-Number: 15719 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Wed, 23 Oct 2019 14:05:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191023/e57a6aa1/attachment.htm>