This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15719 ) Change subject: gsm0508: add functions to calculate beginning of a block ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/15719/5/src/gsm/gsm0502.c File src/gsm/gsm0502.c: https://gerrit.osmocom.org/c/libosmocore/+/15719/5/src/gsm/gsm0502.c@181 PS5, Line 181: struct fn_remap_table *table = fn_remap_table_ptr[channel]; Thanks for implementing the table-lookup-table as per my earlier review comment. However, my review comment also contained something like ... you just have to do OSMO_ASSERT(channel > ARRAY_SIZE(fn_remap_table)). That part is missing here and we can have out-of-bound reads if some code should ever call us with some broken value for 'channel'. At runtime, the enum is just an int, and nothing guarantees that this value is within bounds. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15719 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3d71c66f8c401f5afbad9b1c86c24580dab9e0ce Gerrit-Change-Number: 15719 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Wed, 23 Oct 2019 21:40:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191023/3d537a74/attachment.htm>