Change in libosmo-sccp[master]: ss7: Log local and remote address set upon ASP restart

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Oct 22 19:38:54 UTC 2019


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15786 )

Change subject: ss7: Log local and remote address set upon ASP restart
......................................................................

ss7: Log local and remote address set upon ASP restart

Change-Id: I35c2581923ed3e1f7aff6c137ddf356882bac621
---
M src/osmo_ss7.c
1 file changed, 7 insertions(+), 3 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c
index a0b931e..e7e688d 100644
--- a/src/osmo_ss7.c
+++ b/src/osmo_ss7.c
@@ -465,7 +465,7 @@
  *  \param[in] inst SS7 instance for which we register the user
  *  \param[in] service_ind Service (ISUP, SCCP, ...)
  *  \param[in] user (optional) SS7 user. If present, we will not
- * 		unregister other users 
+ * 		unregister other users
  *  \returns 0 on success; negative on error */
 int osmo_ss7_user_unregister(struct osmo_ss7_instance *inst, uint8_t service_ind,
 			     struct osmo_ss7_user *user)
@@ -1277,9 +1277,13 @@
 {
 	int rc;
 	enum xua_asp_role role;
+	char bufloc[512], bufrem[512];
 
 	OSMO_ASSERT(ss7_initialized);
-	LOGPASP(asp, DLSS7, LOGL_INFO, "Restarting ASP\n");
+	osmo_ss7_asp_peer_snprintf(bufloc, sizeof(bufloc), &asp->cfg.local);
+	osmo_ss7_asp_peer_snprintf(bufrem, sizeof(bufrem), &asp->cfg.remote);
+	LOGPASP(asp, DLSS7, LOGL_INFO, "Restarting ASP %s, %s ==> %s\n",
+	       asp->cfg.name, bufloc, bufrem);
 
 	if (!asp->cfg.is_server) {
 		/* We are in client mode now */
@@ -1312,7 +1316,7 @@
 		rc = osmo_stream_cli_open(asp->client);
 		if (rc < 0) {
 			LOGPASP(asp, DLSS7, LOGL_ERROR, "Unable to open stream"
-				" client for ASP %s\n", asp->cfg.name);
+				" client for ASP %s, %s ==> %s\n", asp->cfg.name, bufloc, bufrem);
 			/* we don't return error in here because osmo_stream_cli_open()
 			   will continue to retry (due to timeout being explicitly set with
 			   osmo_stream_cli_set_reconnect_timeout() above) to connect so the error is transient */

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15786
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I35c2581923ed3e1f7aff6c137ddf356882bac621
Gerrit-Change-Number: 15786
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191022/75b15c82/attachment.htm>


More information about the gerrit-log mailing list