<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/15786">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ss7: Log local and remote address set upon ASP restart<br><br>Change-Id: I35c2581923ed3e1f7aff6c137ddf356882bac621<br>---<br>M src/osmo_ss7.c<br>1 file changed, 7 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c</span><br><span>index a0b931e..e7e688d 100644</span><br><span>--- a/src/osmo_ss7.c</span><br><span>+++ b/src/osmo_ss7.c</span><br><span>@@ -465,7 +465,7 @@</span><br><span>  *  \param[in] inst SS7 instance for which we register the user</span><br><span>  *  \param[in] service_ind Service (ISUP, SCCP, ...)</span><br><span>  *  \param[in] user (optional) SS7 user. If present, we will not</span><br><span style="color: hsl(0, 100%, 40%);">- *             unregister other users </span><br><span style="color: hsl(120, 100%, 40%);">+ *             unregister other users</span><br><span>  *  \returns 0 on success; negative on error */</span><br><span> int osmo_ss7_user_unregister(struct osmo_ss7_instance *inst, uint8_t service_ind,</span><br><span>                            struct osmo_ss7_user *user)</span><br><span>@@ -1277,9 +1277,13 @@</span><br><span> {</span><br><span>       int rc;</span><br><span>      enum xua_asp_role role;</span><br><span style="color: hsl(120, 100%, 40%);">+       char bufloc[512], bufrem[512];</span><br><span> </span><br><span>   OSMO_ASSERT(ss7_initialized);</span><br><span style="color: hsl(0, 100%, 40%);">-   LOGPASP(asp, DLSS7, LOGL_INFO, "Restarting ASP\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_ss7_asp_peer_snprintf(bufloc, sizeof(bufloc), &asp->cfg.local);</span><br><span style="color: hsl(120, 100%, 40%);">+   osmo_ss7_asp_peer_snprintf(bufrem, sizeof(bufrem), &asp->cfg.remote);</span><br><span style="color: hsl(120, 100%, 40%);">+  LOGPASP(asp, DLSS7, LOGL_INFO, "Restarting ASP %s, %s ==> %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+        asp->cfg.name, bufloc, bufrem);</span><br><span> </span><br><span>        if (!asp->cfg.is_server) {</span><br><span>                /* We are in client mode now */</span><br><span>@@ -1312,7 +1316,7 @@</span><br><span>              rc = osmo_stream_cli_open(asp->client);</span><br><span>           if (rc < 0) {</span><br><span>                     LOGPASP(asp, DLSS7, LOGL_ERROR, "Unable to open stream"</span><br><span style="color: hsl(0, 100%, 40%);">-                               " client for ASP %s\n", asp->cfg.name);</span><br><span style="color: hsl(120, 100%, 40%);">+                          " client for ASP %s, %s ==> %s\n", asp->cfg.name, bufloc, bufrem);</span><br><span>                   /* we don't return error in here because osmo_stream_cli_open()</span><br><span>                     will continue to retry (due to timeout being explicitly set with</span><br><span>                     osmo_stream_cli_set_reconnect_timeout() above) to connect so the error is transient */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/15786">change 15786</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-sccp/+/15786"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I35c2581923ed3e1f7aff6c137ddf356882bac621 </div>
<div style="display:none"> Gerrit-Change-Number: 15786 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>