Change in ...osmo-bts[master]: common/l1sap: increase ToA precision for packet Access Bursts

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Oct 4 15:53:54 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/15658 )

Change subject: common/l1sap: increase ToA precision for packet Access Bursts
......................................................................

common/l1sap: increase ToA precision for packet Access Bursts

QTA is a Timing Advance value in units of 1/4 of a symbol. Let's
use ToA256 (1/256 of a symbol) field of L1SAP RACH.ind as a base
for QTA calculation in order to achieve better precision.

Change-Id: I6e6fa7985c430a9bdbd12af2a8b2a5a66f11a41c
---
M src/common/l1sap.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 2874c81..ac1c99d 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -1362,7 +1362,8 @@
 		LOGPFN(DL1P, LOGL_INFO, rach_ind->fn, "RACH for packet access (toa=%d, ra=%d)\n",
 			rach_ind->acc_delay, rach_ind->ra);
 
-		pcu_tx_rach_ind(bts, rach_ind->acc_delay << 2,
+		/* QTA: Timing Advance in units of 1/4 of a symbol */
+		pcu_tx_rach_ind(bts, rach_ind->acc_delay_256bits >> 6,
 			rach_ind->ra, rach_ind->fn, rach_ind->is_11bit,
 			rach_ind->burst_type, PCU_IF_SAPI_RACH);
 		return 0;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15658
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I6e6fa7985c430a9bdbd12af2a8b2a5a66f11a41c
Gerrit-Change-Number: 15658
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191004/9e391555/attachment.htm>


More information about the gerrit-log mailing list