Change in libosmocore[master]: vty/vty.c: log received commands from telnet interface

[neels]

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14974 )

Change subject: vty/vty.c: log received commands from telnet interface
......................................................................


Patch Set 6:

(1 comment)

why not just add the LOGP() on a fixed category and log level? Does it really need to be configurable at all? Was there a particular reason to make it this complex?

If logging vty commands is considered harmful for some reason, we could also add another logging category for it, so it is independently switch-on/off-able.
We have a DLCTRL, why not add a DLVTY.

https://gerrit.osmocom.org/c/libosmocore/+/14974/6/src/vty/vty.c 
File src/vty/vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/14974/6/src/vty/vty.c@1766 
PS6, Line 1766: /* Work around "[level (A|B|C)]" parsing bug */
you can't make multiple arguments optional in a single square brace. Instead try

  [level] [(A|B|C)]



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14974
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I5f6639f6ebc3e8f8df50ef48538df94285b759fd
Gerrit-Change-Number: 14974
Gerrit-PatchSet: 6
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 26 Nov 2019 03:07:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191126/768b6a2f/attachment.htm>