This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14974 ) Change subject: vty/vty.c: log received commands from telnet interface ...................................................................... Patch Set 6: (1 comment) While I see some benefits from logging vty commands (for instance finding last command causing a crash or helping with debug, or change of behavior), I don't think that's the proper way of doing it. Specially I don't like abusing the log levels to enable/disable different things there. So if you want, I'm fine with enabling those with debug. Or add a new logging subsystem for those. Perhaps we can use that one for vty_out() being printed to log files too. https://gerrit.osmocom.org/c/libosmocore/+/14974/6/src/vty/vty.c File src/vty/vty.c: https://gerrit.osmocom.org/c/libosmocore/+/14974/6/src/vty/vty.c@458 PS6, Line 458: LOGP(DLGLOBAL, vty_command_log_level, osmo_sock_get_name_bug + LOGP: looks like a new LOGSOCKP or alike wrapper may be useful here. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14974 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5f6639f6ebc3e8f8df50ef48538df94285b759fd Gerrit-Change-Number: 14974 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: neels <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Mon, 25 Nov 2019 12:08:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191125/662dce47/attachment.htm>