This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16097 ) Change subject: free USB buffer when allocation failed ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/simtrace2/+/16097/1/firmware/libcommon/source/card_emu.c File firmware/libcommon/source/card_emu.c: https://gerrit.osmocom.org/c/simtrace2/+/16097/1/firmware/libcommon/source/card_emu.c@274 PS1, Line 274: msg = msgb_dequeue(queue); Are we sure we are not accidentially dequeing the [only, first] buffer in the queue whihc might currently be in transmit by the USB device peripheral? -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/16097 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ie9ebdd2ff966f67c9afd1ed760f106558f0091ad Gerrit-Change-Number: 16097 Gerrit-PatchSet: 1 Gerrit-Owner: tsaitgaist <kredon at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Sat, 23 Nov 2019 08:15:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191123/ba133036/attachment.htm>