<p><a href="https://gerrit.osmocom.org/c/simtrace2/+/16097">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/16097/1/firmware/libcommon/source/card_emu.c">File firmware/libcommon/source/card_emu.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/simtrace2/+/16097/1/firmware/libcommon/source/card_emu.c@274">Patch Set #1, Line 274:</a> <code style="font-family:monospace,monospace">msg = msgb_dequeue(queue);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Are we sure we are not accidentially dequeing the [only, first] buffer in the queue whihc might currently be in transmit by the USB device peripheral?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/16097">change 16097</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/16097"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie9ebdd2ff966f67c9afd1ed760f106558f0091ad </div>
<div style="display:none"> Gerrit-Change-Number: 16097 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: tsaitgaist <kredon@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 23 Nov 2019 08:15:07 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>