This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/16137 ) Change subject: respawn.sh: Add logging and limit loop iterations ...................................................................... Patch Set 1: Code-Review-1 (1 comment) -1 because of "$@" > Patch Set 1: > > Can we have only a single instance of respawn.sh? I don't like code duplication... This would be nice, and also with Release.key, which is currently copied over and over. The problem is, that docker won't follow symlinks while building images from the Dockerfile (https://github.com/moby/moby/issues/1676#issuecomment-23878459). But we could modify the commonly used Makefile to copy the files from a subdir in docker-playground.git, together with commonly used files, into a temporary directory before starting the build. (Obviously that would go into a separate patch.) https://gerrit.osmocom.org/c/docker-playground/+/16137/1/osmo-bts-latest/respawn.sh File osmo-bts-latest/respawn.sh: https://gerrit.osmocom.org/c/docker-playground/+/16137/1/osmo-bts-latest/respawn.sh@9 PS1, Line 9: $* This should be "$@" (with the quotation marks). Otherwise, arguments are not passed correctly. For example: $ echo "hello" > "/tmp/test file" $ ./respawn.sh cat "/tmp/test file" 0: starting: cat /tmp/test file cat: /tmp/test: No such file or directory cat: file: No such file or directory Related: https://unix.stackexchange.com/a/41595 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/16137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Icc8cac889d94d4cce7d6365781d5b5364404b5b9 Gerrit-Change-Number: 16137 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Thu, 21 Nov 2019 10:37:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191121/26c84014/attachment.htm>