<p style="white-space: pre-wrap; word-wrap: break-word;">-1 because of "$@"</p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 1:</p><p style="white-space: pre-wrap; word-wrap: break-word;">Can we have only a single instance of respawn.sh? I don't like code duplication...</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">This would be nice, and also with Release.key, which is currently copied over and over.</p><p style="white-space: pre-wrap; word-wrap: break-word;">The problem is, that docker won't follow symlinks while building images from the Dockerfile (https://github.com/moby/moby/issues/1676#issuecomment-23878459). But we could modify the commonly used Makefile to copy the files from a subdir in docker-playground.git, together with commonly used files, into a temporary directory before starting the build. (Obviously that would go into a separate patch.)</p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/c/docker-playground/+/16137">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/docker-playground/+/16137/1/osmo-bts-latest/respawn.sh">File osmo-bts-latest/respawn.sh:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/docker-playground/+/16137/1/osmo-bts-latest/respawn.sh@9">Patch Set #1, Line 9:</a> <code style="font-family:monospace,monospace">$*</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This should be "$@" (with the quotation marks). Otherwise, arguments are not passed correctly. For example:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> $ echo "hello" > "/tmp/test file"<br> $ ./respawn.sh cat "/tmp/test file"<br> 0: starting: cat /tmp/test file     <br> cat: /tmp/test: No such file or directory<br> cat: file: No such file or directory</pre><p style="white-space: pre-wrap; word-wrap: break-word;">Related: https://unix.stackexchange.com/a/41595</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/docker-playground/+/16137">change 16137</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/docker-playground/+/16137"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: docker-playground </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icc8cac889d94d4cce7d6365781d5b5364404b5b9 </div>
<div style="display:none"> Gerrit-Change-Number: 16137 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 21 Nov 2019 10:37:22 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>