Change in osmocom-bb[master]: trxcon/trx_if.c: Dropping UL bursts is a noticeable event

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Fri May 31 16:07:15 UTC 2019


Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/14276 )

Change subject: trxcon/trx_if.c: Dropping UL bursts is a noticeable event
......................................................................

trxcon/trx_if.c: Dropping UL bursts is a noticeable event

Therefore we should use LOGL_ERROR instead of LOGL_DEBUG.

Change-Id: If5084feb9e847d212530b1a5985390405d91008b
---
M src/host/trxcon/trx_if.c
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Vadim Yanitskiy: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/host/trxcon/trx_if.c b/src/host/trxcon/trx_if.c
index ca78349..55d7034 100644
--- a/src/host/trxcon/trx_if.c
+++ b/src/host/trxcon/trx_if.c
@@ -614,10 +614,11 @@
 	 * We must be sure that we have clock,
 	 * and we have sent all control data
 	 *
-	 * TODO: should we wait in TRX_STATE_RSP_WAIT state?
+	 * TODO: introduce proper state machines for both
+	 *       transceiver and its TRXC interface.
 	 */
 	if (trx->fsm->state != TRX_STATE_ACTIVE) {
-		LOGP(DTRXD, LOGL_DEBUG, "Ignoring TX data, "
+		LOGP(DTRXD, LOGL_ERROR, "Ignoring TX data, "
 			"transceiver isn't ready\n");
 		return -EAGAIN;
 	}

-- 
To view, visit https://gerrit.osmocom.org/14276
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If5084feb9e847d212530b1a5985390405d91008b
Gerrit-Change-Number: 14276
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190531/192d05eb/attachment.html>


More information about the gerrit-log mailing list