<p>Vadim Yanitskiy <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/14276">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Vadim Yanitskiy: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trxcon/trx_if.c: Dropping UL bursts is a noticeable event<br><br>Therefore we should use LOGL_ERROR instead of LOGL_DEBUG.<br><br>Change-Id: If5084feb9e847d212530b1a5985390405d91008b<br>---<br>M src/host/trxcon/trx_if.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/trxcon/trx_if.c b/src/host/trxcon/trx_if.c</span><br><span>index ca78349..55d7034 100644</span><br><span>--- a/src/host/trxcon/trx_if.c</span><br><span>+++ b/src/host/trxcon/trx_if.c</span><br><span>@@ -614,10 +614,11 @@</span><br><span> * We must be sure that we have clock,</span><br><span> * and we have sent all control data</span><br><span> *</span><br><span style="color: hsl(0, 100%, 40%);">- * TODO: should we wait in TRX_STATE_RSP_WAIT state?</span><br><span style="color: hsl(120, 100%, 40%);">+ * TODO: introduce proper state machines for both</span><br><span style="color: hsl(120, 100%, 40%);">+ * transceiver and its TRXC interface.</span><br><span> */</span><br><span> if (trx->fsm->state != TRX_STATE_ACTIVE) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGP(DTRXD, LOGL_DEBUG, "Ignoring TX data, "</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DTRXD, LOGL_ERROR, "Ignoring TX data, "</span><br><span> "transceiver isn't ready\n");</span><br><span> return -EAGAIN;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/14276">change 14276</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/14276"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: If5084feb9e847d212530b1a5985390405d91008b </div>
<div style="display:none"> Gerrit-Change-Number: 14276 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>