Change in osmo-bts[master]: lc15, sysmo, oc2g: fix dsp-trace-flag command

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue May 28 17:56:18 UTC 2019


Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/14239


Change subject: lc15,sysmo,oc2g: fix dsp-trace-flag command
......................................................................

lc15,sysmo,oc2g: fix dsp-trace-flag command

Remove the '~' from '|= flag', it is plain wrong.

This affects the correct parsing of DSP trace flags from the config
file only.  The bug is not present in the interactive VTY command
at runtime.

Change-Id: I915971f49642967c969f5dd475e8faa960ef3960
---
M src/osmo-bts-litecell15/lc15bts_vty.c
M src/osmo-bts-oc2g/oc2gbts_vty.c
M src/osmo-bts-sysmo/sysmobts_vty.c
3 files changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/39/14239/1

diff --git a/src/osmo-bts-litecell15/lc15bts_vty.c b/src/osmo-bts-litecell15/lc15bts_vty.c
index d0edc88..d27ec28 100644
--- a/src/osmo-bts-litecell15/lc15bts_vty.c
+++ b/src/osmo-bts-litecell15/lc15bts_vty.c
@@ -88,7 +88,7 @@
 	unsigned int flag;
 
 	flag = get_string_value(lc15bts_tracef_names, argv[1]);
-	pinst->u.lc15.dsp_trace_f |= ~flag;
+	pinst->u.lc15.dsp_trace_f |= flag;
 
 	return CMD_SUCCESS;
 }
diff --git a/src/osmo-bts-oc2g/oc2gbts_vty.c b/src/osmo-bts-oc2g/oc2gbts_vty.c
index 4c3915b..1f092dd 100644
--- a/src/osmo-bts-oc2g/oc2gbts_vty.c
+++ b/src/osmo-bts-oc2g/oc2gbts_vty.c
@@ -114,7 +114,7 @@
 	unsigned int flag;
 
 	flag = get_string_value(oc2gbts_tracef_names, argv[1]);
-	pinst->u.oc2g.dsp_trace_f |= ~flag;
+	pinst->u.oc2g.dsp_trace_f |= flag;
 
 	return CMD_SUCCESS;
 }
diff --git a/src/osmo-bts-sysmo/sysmobts_vty.c b/src/osmo-bts-sysmo/sysmobts_vty.c
index b105bf4..3199c8e 100644
--- a/src/osmo-bts-sysmo/sysmobts_vty.c
+++ b/src/osmo-bts-sysmo/sysmobts_vty.c
@@ -179,7 +179,7 @@
 	unsigned int flag;
 
 	flag = get_string_value(femtobts_tracef_names, argv[1]);
-	pinst->u.sysmobts.dsp_trace_f |= ~flag;
+	pinst->u.sysmobts.dsp_trace_f |= flag;
 
 	return CMD_SUCCESS;
 }

-- 
To view, visit https://gerrit.osmocom.org/14239
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I915971f49642967c969f5dd475e8faa960ef3960
Gerrit-Change-Number: 14239
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190528/f3bfbf37/attachment.html>


More information about the gerrit-log mailing list