<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/14239">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lc15,sysmo,oc2g: fix dsp-trace-flag command<br><br>Remove the '~' from '|= flag', it is plain wrong.<br><br>This affects the correct parsing of DSP trace flags from the config<br>file only.  The bug is not present in the interactive VTY command<br>at runtime.<br><br>Change-Id: I915971f49642967c969f5dd475e8faa960ef3960<br>---<br>M src/osmo-bts-litecell15/lc15bts_vty.c<br>M src/osmo-bts-oc2g/oc2gbts_vty.c<br>M src/osmo-bts-sysmo/sysmobts_vty.c<br>3 files changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/39/14239/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-litecell15/lc15bts_vty.c b/src/osmo-bts-litecell15/lc15bts_vty.c</span><br><span>index d0edc88..d27ec28 100644</span><br><span>--- a/src/osmo-bts-litecell15/lc15bts_vty.c</span><br><span>+++ b/src/osmo-bts-litecell15/lc15bts_vty.c</span><br><span>@@ -88,7 +88,7 @@</span><br><span>      unsigned int flag;</span><br><span> </span><br><span>       flag = get_string_value(lc15bts_tracef_names, argv[1]);</span><br><span style="color: hsl(0, 100%, 40%);">- pinst->u.lc15.dsp_trace_f |= ~flag;</span><br><span style="color: hsl(120, 100%, 40%);">+        pinst->u.lc15.dsp_trace_f |= flag;</span><br><span> </span><br><span>    return CMD_SUCCESS;</span><br><span> }</span><br><span>diff --git a/src/osmo-bts-oc2g/oc2gbts_vty.c b/src/osmo-bts-oc2g/oc2gbts_vty.c</span><br><span>index 4c3915b..1f092dd 100644</span><br><span>--- a/src/osmo-bts-oc2g/oc2gbts_vty.c</span><br><span>+++ b/src/osmo-bts-oc2g/oc2gbts_vty.c</span><br><span>@@ -114,7 +114,7 @@</span><br><span>      unsigned int flag;</span><br><span> </span><br><span>       flag = get_string_value(oc2gbts_tracef_names, argv[1]);</span><br><span style="color: hsl(0, 100%, 40%);">- pinst->u.oc2g.dsp_trace_f |= ~flag;</span><br><span style="color: hsl(120, 100%, 40%);">+        pinst->u.oc2g.dsp_trace_f |= flag;</span><br><span> </span><br><span>    return CMD_SUCCESS;</span><br><span> }</span><br><span>diff --git a/src/osmo-bts-sysmo/sysmobts_vty.c b/src/osmo-bts-sysmo/sysmobts_vty.c</span><br><span>index b105bf4..3199c8e 100644</span><br><span>--- a/src/osmo-bts-sysmo/sysmobts_vty.c</span><br><span>+++ b/src/osmo-bts-sysmo/sysmobts_vty.c</span><br><span>@@ -179,7 +179,7 @@</span><br><span>      unsigned int flag;</span><br><span> </span><br><span>       flag = get_string_value(femtobts_tracef_names, argv[1]);</span><br><span style="color: hsl(0, 100%, 40%);">-        pinst->u.sysmobts.dsp_trace_f |= ~flag;</span><br><span style="color: hsl(120, 100%, 40%);">+    pinst->u.sysmobts.dsp_trace_f |= flag;</span><br><span> </span><br><span>        return CMD_SUCCESS;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/14239">change 14239</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/14239"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I915971f49642967c969f5dd475e8faa960ef3960 </div>
<div style="display:none"> Gerrit-Change-Number: 14239 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>