Change in osmo-sgsn[master]: osmo-sgsn: get rid of OSMO_ASSERT() in 'auth-policy' handler

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon May 27 08:31:55 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/14195 )

Change subject: osmo-sgsn: get rid of OSMO_ASSERT() in 'auth-policy' handler
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/14195/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/14195/1//COMMIT_MSG@22
PS1, Line 22:   auth-policy c
So you say in this case argv[0] is "c" instead of "closed"? That's IMHO wrong and should be fixed in VTY libosmocore code.



-- 
To view, visit https://gerrit.osmocom.org/14195
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If9b0c0d031477ca87786aab5c269d00748e896c8
Gerrit-Change-Number: 14195
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 27 May 2019 08:31:55 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190527/422b05f7/attachment.html>


More information about the gerrit-log mailing list