Change in osmo-ttcn3-hacks[master]: Add Osmux support and tests for MGW

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun May 26 09:18:08 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/14046 )

Change subject: Add Osmux support and tests for MGW
......................................................................


Patch Set 5:

(3 comments)

https://gerrit.osmocom.org/#/c/14046/5/library/MGCP_Templates.ttcn
File library/MGCP_Templates.ttcn:

https://gerrit.osmocom.org/#/c/14046/5/library/MGCP_Templates.ttcn@333
PS5, Line 333: 			return "ERROR-wrong-negative-value";
do you really want this as an error message in the string and then make the caller use it?  Why not setverdict(fail, "netative value passed to f_mgcp_osmux_cid_encode()") or even go as far as to test.stop or whatever...


https://gerrit.osmocom.org/#/c/14046/5/library/OSMUX_Types.ttcn
File library/OSMUX_Types.ttcn:

https://gerrit.osmocom.org/#/c/14046/5/library/OSMUX_Types.ttcn@39
PS5, Line 39: //  variant (ext_header) "PRESENCE(extension_ind = '1'B)";
            : //  variant (CSRC_count) "LENGTHTO(CSRCs), UNIT(elements)";
            :   variant "FIELDORDER(msb)"
do we have any extensions here? do we expect them? otherwise remove the comments?


https://gerrit.osmocom.org/#/c/14046/5/library/OSMUX_Types.ttcn@48
PS5, Line 48: //  variant (ext_header) "PRESENCE(extension_ind = '1'B)";
do we have any extensions here? do we expect them? otherwise remove the comments?



-- 
To view, visit https://gerrit.osmocom.org/14046
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb58b2a4e08d6f30cfe347c217794d0d1310954f
Gerrit-Change-Number: 14046
Gerrit-PatchSet: 5
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Sun, 26 May 2019 09:18:08 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190526/15f5de75/attachment.html>


More information about the gerrit-log mailing list