Change in osmo-ttcn3-hacks[master]: Add Osmux support and tests for MGW

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon May 27 09:10:05 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/14046 )

Change subject: Add Osmux support and tests for MGW
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.osmocom.org/#/c/14046/5/library/MGCP_Templates.ttcn
File library/MGCP_Templates.ttcn:

https://gerrit.osmocom.org/#/c/14046/5/library/MGCP_Templates.ttcn@333
PS5, Line 333: 			return "ERROR-wrong-negative-value";
> do you really want this as an error message in the string and then make the caller use it?  Why not  […]
MgcpOsmuxCid is actually defined as (-1 .. 255), so I think I can safely drop this check.



-- 
To view, visit https://gerrit.osmocom.org/14046
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb58b2a4e08d6f30cfe347c217794d0d1310954f
Gerrit-Change-Number: 14046
Gerrit-PatchSet: 5
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 27 May 2019 09:10:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190527/1e53eea8/attachment.html>


More information about the gerrit-log mailing list