Change in osmo-bts[master]: cbch: Add counters; queue length limits and CBCH LOAD reporting

osmith gerrit-no-reply at lists.osmocom.org
Wed May 22 11:37:33 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/14113 )

Change subject: cbch: Add counters; queue length limits and CBCH LOAD reporting
......................................................................


Patch Set 3:

(5 comments)

Mostly looking good, I've commented on some minor things.

https://gerrit.osmocom.org/#/c/14113/3//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/14113/3//COMMIT_MSG@10
PS3, Line 10: tab
tap?


https://gerrit.osmocom.org/#/c/14113/3//COMMIT_MSG@11
PS3, Line 11: SSMCB
SMSCB?


https://gerrit.osmocom.org/#/c/14113/3/src/common/bts.c
File src/common/bts.c:

https://gerrit.osmocom.org/#/c/14113/3/src/common/bts.c@110
PS3, Line 110: queeud
queued


https://gerrit.osmocom.org/#/c/14113/3/src/common/rsl.c
File src/common/rsl.c:

https://gerrit.osmocom.org/#/c/14113/3/src/common/rsl.c@1654
PS3, Line 1654: (overflow & 1)
Isn't the result the same as directly using "overflow", as it is a boolean?


https://gerrit.osmocom.org/#/c/14113/3/src/common/vty.c
File src/common/vty.c:

https://gerrit.osmocom.org/#/c/14113/3/src/common/vty.c@695
PS3, Line 695: 	"Maximum queue length for SMSCB (CBCH) queue. In count of messages/pages")
I'd mention the default value here, same with the options below.



-- 
To view, visit https://gerrit.osmocom.org/14113
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7068c7937a60a900c40439115bb84dc3ee0d061f
Gerrit-Change-Number: 14113
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Wed, 22 May 2019 11:37:33 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190522/747400ce/attachment.html>


More information about the gerrit-log mailing list