Change in osmo-bts[master]: cbch: Add counters; queue length limits and CBCH LOAD reporting

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed May 22 12:38:27 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/14113 )

Change subject: cbch: Add counters; queue length limits and CBCH LOAD reporting
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/#/c/14113/3//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/14113/3//COMMIT_MSG@10
PS3, Line 10: tab
> tap?
no, we don't want to tap into it, but we want to keep a tab[le], we want to tabulate, ... using it in the meaning of https://www.dict.cc/englisch-deutsch/tab.html


https://gerrit.osmocom.org/#/c/14113/3/src/common/rsl.c
File src/common/rsl.c:

https://gerrit.osmocom.org/#/c/14113/3/src/common/rsl.c@1654
PS3, Line 1654: (overflow & 1)
> Isn't the result the same as directly using "overflow", as it is a boolean?
yes, due to the fact that true == 1 and false == 0.   Still I sometimes like to make things explicit.  I'm sure the compiler will remove whatever additional statements that have no effect on the object code.



-- 
To view, visit https://gerrit.osmocom.org/14113
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7068c7937a60a900c40439115bb84dc3ee0d061f
Gerrit-Change-Number: 14113
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Wed, 22 May 2019 12:38:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190522/027203cf/attachment.html>


More information about the gerrit-log mailing list