Change in osmo-sgsn[master]: libgtp: don't call sgsn_pdp_ctx_free() with NULL pdp

Keith Whyte gerrit-no-reply at lists.osmocom.org
Sat May 18 10:28:13 UTC 2019


Hello lynxis lazus, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/13929

to look at the new patch set (#3).

Change subject: libgtp: don't call sgsn_pdp_ctx_free() with NULL pdp
......................................................................

libgtp: don't call sgsn_pdp_ctx_free() with NULL pdp

In [osmo-ggsn]:gtp.c:gtp_delete_pdp_conf():

When the condition pdp_getgtp1(&pdp, get_tei(pack)) returns true
we then call gsn->cb_conf(type, EOF, NULL, cbp);

This NULL pdp will cause a crash later in
delete_pdp_conf()
  sgsn_pdp_ctx_free()
    rate_ctr_group_free()

So just return on NULL pdp to prevent this crash.

Related: OS#3956
Change-Id: I184dcce27b26104c61d80b2d910388d5d3323def
---
M src/gprs/sgsn_libgtp.c
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/29/13929/3
-- 
To view, visit https://gerrit.osmocom.org/13929
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I184dcce27b26104c61d80b2d910388d5d3323def
Gerrit-Change-Number: 13929
Gerrit-PatchSet: 3
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190518/6350d8fd/attachment.html>


More information about the gerrit-log mailing list