Change in osmo-sgsn[master]: libgtp: don't call sgsn_pdp_ctx_free() w/o MM ctx

Keith Whyte gerrit-no-reply at lists.osmocom.org
Fri May 10 16:12:04 UTC 2019


Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13929 )

Change subject: libgtp: don't call sgsn_pdp_ctx_free() w/o MM ctx
......................................................................


Patch Set 2:

> I think the problem lies somewhere else. 

Agreed.

>IMHO: Calling free() w/o MM ctx is fine.

Well, if you pass that pctx into 
sgsn_pdp_ctx_free() after the MM context has been cleared, 
it WILL crash with 
rate_ctr_group_free(pdp->ctrg);

I don't see how this is fine. :-/


-- 
To view, visit https://gerrit.osmocom.org/13929
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I184dcce27b26104c61d80b2d910388d5d3323def
Gerrit-Change-Number: 13929
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Fri, 10 May 2019 16:12:04 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190510/f65a7345/attachment.html>


More information about the gerrit-log mailing list