Change in osmo-ttcn3-hacks[master]: RTP_Emulation: Avoid failure if T_transmit triggers between bind and ...

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri May 17 17:05:36 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/14078 )

Change subject: RTP_Emulation: Avoid failure if T_transmit triggers between bind and connect
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/14078/1/library/RTP_Emulation.ttcn
File library/RTP_Emulation.ttcn:

https://gerrit.osmocom.org/#/c/14078/1/library/RTP_Emulation.ttcn@473
PS1, Line 473: 		[g_tx_connected] T_transmit.timeout {
I am not sure if the condition should be here or simply:

""""
if (g_tx_connected) {
f_tx_rtp(g_cfg.tx_fixed_payload);
g_stats_rtp.num_pkts_tx := g_stats_rtp.num_pkts_tx+1;
			g_stats_rtp.bytes_payload_tx := g_stats_rtp.bytes_payload_tx + 							lengthof(g_cfg.tx_fixed_payload);
}

T_transmit.start;
""""

What happens if timer timeout triggers and g_tx_connected is false? is the timeout event delayed until g_tx_connected is true? or is it discarded? In that case the g_tx_connected check should be checked with "if" block as shown above, otherwise T_transmit won't be re-enabled and Tx will stop forever (or until next RTPEM_mode message) and that's not desirable.



-- 
To view, visit https://gerrit.osmocom.org/14078
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I20e7aed35bb28200e30ee5efc718f77e036d8262
Gerrit-Change-Number: 14078
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 17 May 2019 17:05:36 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190517/0c49f3fd/attachment.html>


More information about the gerrit-log mailing list