Change in osmo-ttcn3-hacks[master]: RTP_Emulation: Avoid failure if T_transmit triggers between bind and ...

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri May 17 17:32:01 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/14078 )

Change subject: RTP_Emulation: Avoid failure if T_transmit triggers between bind and connect
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/14078/1/library/RTP_Emulation.ttcn
File library/RTP_Emulation.ttcn:

https://gerrit.osmocom.org/#/c/14078/1/library/RTP_Emulation.ttcn@473
PS1, Line 473: 		[g_tx_connected] T_transmit.timeout {
> I am not sure if the condition should be here or simply: […]
AFAICT: The timeout expiration event is in the inbound port queue until some match statement dequeues it.  If there is no matching statement [yet], I would expect it to be delayed until g_tx_connected is true. But the best approach is to write a small 10-line test program and try it out....



-- 
To view, visit https://gerrit.osmocom.org/14078
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I20e7aed35bb28200e30ee5efc718f77e036d8262
Gerrit-Change-Number: 14078
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Fri, 17 May 2019 17:32:01 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190517/93ecbcc3/attachment.html>


More information about the gerrit-log mailing list