Change in osmo-hlr[master]: Create subscribers on demand

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Fri May 10 11:40:05 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13713 )

Change subject: Create subscribers on demand
......................................................................


Patch Set 3:

(4 comments)

https://gerrit.osmocom.org/#/c/13713/3/src/hlr.h
File src/hlr.h:

https://gerrit.osmocom.org/#/c/13713/3/src/hlr.h@63
PS3, Line 63: uint8_t
Unsigned int. No need to use fixed-size type here.


https://gerrit.osmocom.org/#/c/13713/3/src/hlr.c
File src/hlr.c:

https://gerrit.osmocom.org/#/c/13713/3/src/hlr.c@158
PS3, Line 158: int
Unsigned int.


https://gerrit.osmocom.org/#/c/13713/3/src/hlr.c@173
PS3, Line 173: rand_msisdn_len
Feel free to inverse this statement, so this would allow to reduce code nesting:

  if (!rand_msisdn_len)
    return 0;


https://gerrit.osmocom.org/#/c/13713/3/src/hlr_vty.c
File src/hlr_vty.c:

https://gerrit.osmocom.org/#/c/13713/3/src/hlr_vty.c@358
PS3, Line 358: 3
AFAIR, a single digit is also a valid MSISDN ;)



-- 
To view, visit https://gerrit.osmocom.org/13713
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c9fe93f5c24b5e9fefb513c4d049fb7ebd47ecd
Gerrit-Change-Number: 13713
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Fri, 10 May 2019 11:40:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190510/f29ffc6a/attachment.html>


More information about the gerrit-log mailing list