This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/13713 ) Change subject: Create subscribers on demand ...................................................................... Patch Set 3: (5 comments) jenkins will fail to build this, due to the libosmocore dependency. https://gerrit.osmocom.org/#/c/13713/2/src/hlr.h File src/hlr.h: https://gerrit.osmocom.org/#/c/13713/2/src/hlr.h@63 PS2, Line 63: uin > unsigned Done https://gerrit.osmocom.org/#/c/13713/2/src/hlr.c File src/hlr.c: https://gerrit.osmocom.org/#/c/13713/2/src/hlr.c@154 PS2, Line 154: > AFAIR, I just used a random number, because in the original patch the MSISDN length was hard-coded. […] I've added the constant here, and use that in the next patch: https://gerrit.osmocom.org/#/c/libosmocore/+/13961 https://gerrit.osmocom.org/#/c/13713/2/src/hlr.c@178 PS2, Line 178: if (!rc) > I just realized that we may end up with an infinity loop here, if osmo_get_rand_id() constantly fail […] Done https://gerrit.osmocom.org/#/c/13713/2/src/hlr_vty.c File src/hlr_vty.c: https://gerrit.osmocom.org/#/c/13713/2/src/hlr_vty.c@362 PS2, Line 362: efau > it's a bit tricky. I think 3GPP calls it "combined". You can e.g. […] Changed to "cs+ps" https://gerrit.osmocom.org/#/c/13713/2/src/hlr_vty.c@365 PS2, Line 365: ircuit and packet switched NAM > I thought it's "Network Access Mode" :D lol, wikipedia tricked me there ;D -- To view, visit https://gerrit.osmocom.org/13713 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c9fe93f5c24b5e9fefb513c4d049fb7ebd47ecd Gerrit-Change-Number: 13713 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Fri, 10 May 2019 10:11:30 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190510/db07ba68/attachment.htm>